Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] User 型の見直し #106

Open
Tracked by #108
h-takeyeah opened this issue Apr 6, 2024 · 2 comments
Open
Tracked by #108

[REFACTOR] User 型の見直し #106

h-takeyeah opened this issue Apr 6, 2024 · 2 comments
Assignees
Labels

Comments

@h-takeyeah
Copy link
Collaborator

types/user.tsのUser型がAPIに沿ってない。そもそもOpenAPIのcomponents UserのプロパティがnullableなのとAPI側に寄せるとスネークケースを使わないといけないことの2点が気に入らなくて独自に型を私が作った。

でも1点目はOpenAPIにrequiredを書けばよい、2点目は私のただのお気持ち、なので今の実装はAPIからずれるだけで負債でしかない。この辺直す。

@h-takeyeah h-takeyeah self-assigned this Apr 6, 2024
@KinjiKawaguchi
Copy link
Member

@h-takeyeah このIssueRELEASEのどこかに紐づけてほしいです

@KinjiKawaguchi KinjiKawaguchi mentioned this issue Apr 6, 2024
16 tasks
@h-takeyeah
Copy link
Collaborator Author

おっと、見た時点で、紐づけられていました。見るの遅れてすみません。私も「できれば」に入れるつもりだったのでこれで大丈夫です

@KinjiKawaguchi KinjiKawaguchi mentioned this issue Apr 18, 2024
13 tasks
@KinjiKawaguchi KinjiKawaguchi added Status: In Progress 対応中 and removed Status: On Hold 保留 labels Aug 7, 2024
@KinjiKawaguchi KinjiKawaguchi added this to the v0.1.0 milestone Aug 7, 2024
@KinjiKawaguchi KinjiKawaguchi removed this from the v0.1.0 milestone Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants