Beta task checklist

[dreamwhisper]

• Add error message if post type added to pattern no longer exists. eg. A post type added to your pattern no longer exists. / You have a post type in your pattern that doesn't exist in WordPress.
• Renaming a pattern creates a new copy. Fix renaming bug where there were 2 patterns #61
• consider doing a couple of things when a theme is changed:
  - Delete all pm_pattern posts (these are not needed as we pull from files) After switching themes, delete all pm_pattern posts #62
  - Send a notice through the heartbeat API to any patterns still open that says The theme was changed. This pattern does not exist in this theme. Please close this tab. In the editor, show a notice that the theme changed #65
• Make sure child themes work If the theme is a child theme, save patterns to the child theme #69
• Make sure content isn't stale when using back button.
• Ensure assets save appropriately. (related to tree-shaking, which is removed now) Bring back tree shaking #91
• Deleting title on the edit screen, then saving results in a php error Don't allow saving if there's no pattern title, or if it's a duplicate #67
• Ensure error messages are read by screen readers. wp.a11y.speak
• Make sure the previews resize with a browser resize. Fix issue with preview width when window is resized #109
• Wide alignment not working in pattern editor in 6.2 beta.
• Default width from theme.json not working.

Feel free to edit as needed. We could also create a project if we feel it is needed.

[kienstra]

Working on:

Renaming a pattern creates a new copy.

[kienstra]

Also working on:

Delete all pm_pattern posts (these are not needed as we pull from files)

[kienstra]

Could you expand on this?

Make sure content isn't stale when using back button.

[kienstra]

Also working on:

Send a notice through the heartbeat API to any patterns still open that says The theme was changed. This pattern does not exist in this theme. Please close this tab.

[kienstra]

Hi @dreamwhisper,
Could you expand on this, please?

Make sure content isn't stale when using back button.

(If that was your idea)

[dreamwhisper]

@kienstra Might need @johnstonphilip to expand on that one. I think it's that the previews aren't up to date with what should be showing.

[kienstra]

Ah, that makes sense! Thanks!

[kienstra]

If it would help, I could demo this in Sprint Review:

• Send a notice through the heartbeat API to any patterns still open that says The theme was changed. This pattern does not exist in this theme. Please close this tab. In the editor, show a notice that the theme changed #65
• Deleting title on the edit screen, then saving results in a php error Don't allow saving if there's no pattern title, or if it's a duplicate #67
• Make sure child themes work If the theme is a child theme, save patterns to the child theme #69

[johnstonphilip]

Alignments should be fixed with WordPress/gutenberg#48380

[kienstra]

Hi @dreamwhisper,
Is this working now?

Ensure assets save appropriately.

Hope you had a great weekend.

[kienstra]

Hi @johnstonphilip,
Do you know about this, and whether it's still an issue?

Make sure content isn't stale when using back button.

Hope your week's off to a great start.

[johnstonphilip]

@kienstra Yeah I think this is still happeneing (on my tests it is). To replicate:

1. Create a new pattern.
2. After saving it, click back
3. Notice that new pattern doesn't show in the list of available patterns

This is because the browser shows a cached version of the HTML, and since our app's initial state is populated from that, it isn't up to date.

To fix this, I think we'd have to fetch the data from an API upon first render. Unless there's some way of forcing a browser to load fresh, even on a back click.

[johnstonphilip]

Possible solution to the back-button-stale problem: https://stackoverflow.com/questions/43043113/how-to-force-reloading-a-page-when-using-browser-back-button

[kienstra]

Oh thanks, I see that also. Interesting idea about to 'fetch the data from an API upon first render,' and good find of that StackOverflow question.

[kienstra]

Hi @johnstonphilip,

This is because the browser shows a cached version of the HTML, and since our app's initial state is populated from that, it isn't up to date.

Maybe this is crazy, but what do you think about ignoring this bug?

The same issue exists when creating a new post of type 'post'. Maybe you knew about this already, I just learned about it:

1. Go to /wp-admin/edit.php
2. Click 'Add New':

3. Add a title like 'New Post':

4. Publish
5. Use the browser back button
6. Expected: 'New Post' is in the post list:

9. Actual: It's not in the list

It's how the browser works, though it's definitely a bad UX 😄

To fix this, I think we'd have to fetch the data from an API upon first render.

Good idea, this would be pretty easy to implement.

But it'd be a lot of boilerplate code, like registering a get-patterns endpoint, and adding another useEffect() to load the patterns.

[johnstonphilip]

Yeah. An alternative might be if we can provide some way of getting back to the patterns view without clicking "back", that would be enough. I suppose the admin sidebar Patterns button does that, though it's likely not showing for most people who have the block editor open in full-screen mode. We could leave this and wait for beta feedback too.

[kienstra]

Ah, like this 'back' button?

On clicking it, the newly created pattern shows.