Skip to content
This repository has been archived by the owner on Jun 14, 2022. It is now read-only.

e2e tests run on every commit #379

Open
mindctrl opened this issue Jun 5, 2020 · 0 comments
Open

e2e tests run on every commit #379

mindctrl opened this issue Jun 5, 2020 · 0 comments

Comments

@mindctrl
Copy link
Contributor

mindctrl commented Jun 5, 2020

The Circle config implies that we want e2e tests to run only when tags are created.

- e2e-tests:
filters:
tags:
only: /.*/

But they run on every commit, because the config is missing the branch ignore part like we use elsewhere.

branches:
ignore: /.*/

Here's a workflow that run when a commit was pushed, and you can see the e2e tests ran.

https://app.circleci.com/pipelines/github/studiopress/atomic-blocks/648/workflows/15ef81a1-5d15-4d0b-a3a7-b3d50456122d

We just need to add the branch ignore logic to the e2e-tests workflow.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant