Fix Stream Error Handling in Strophe v3.0.1 #754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary:
In Strophe.js version 3.0.1, the
Strophe.error
method is unable to retrieve and process the stream error details.Currently, error details are only logged to the console instead of being handled.
Previously, custom error handling could be implemented as follows:
Fix Details:
Strophe.error(errorString)
has been added in the_checkStreamError
method immediately after logging the error to the console.Strophe.error
method override to capture stream error details, allowing custom error handling to function as expected.Testing:
Verified that
Strophe.error
successfully captures and processes stream error details with the custom error handling code.