-
Notifications
You must be signed in to change notification settings - Fork 57
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Describe the bug
When pg-schema-diff generates a plan, functions defined with RETURNS SETOF "MyTable" are scheduled before the referenced table.
The dependency exists in PostgreSQL's pg_depend, so the information is available.
Expected behavior
pg-schema-diff should detect table dependencies referenced by functions and ensure that the functions are created after their dependencies.
To Reproduce
- Add the schema below to a migration file.
- Run pg-schema-diff (plan/apply) against an empty database.
- Observe
ERROR: relation "JobRun" does not existbecause the function runs before the table is created.
-- File: schema.sql
CREATE TABLE "JobRun" (
"runId" BIGINT GENERATED BY DEFAULT AS IDENTITY PRIMARY KEY,
"type" TEXT NOT NULL,
"status" TEXT NOT NULL
);
CREATE OR REPLACE FUNCTION "jobRunClaimNext"(p_types TEXT[])
RETURNS SETOF "JobRun"
LANGUAGE sql
AS $$
SELECT r.*
FROM "JobRun" AS r
WHERE r."status" = 'PENDING'
AND r."type" = ANY (p_types)
LIMIT 1;
$$;
Context
pg-schema-diff version: v1.0.2
pg-schema-diff usage: CLI
Postgres version: 17
pg_dump of database: N/A
Possible solution plan
I've never touched a line of Go code, so I passed the above info to Claude, and here's a summary of what it says:
function_sql_vertex_generator.go: Lines 81-100:GetAddAlterDependenciesonly tracks function-to-function dependencies viaDependsOnFunctions- No mechanism to track table references in function bodies
- Query
pg_dependto find actual table dependencies (similar toGetViews) - Add a
TableDependenciesfield toschema.Function(likeView.TableDependencies) - Extend
GetDependsOnFunctionsquery or create a newGetDependsOnTablesquery - Use these dependencies in
GetAddAlterDependencies
Alternatively, if there were a way to impose order from the command line or via the naming of the .sql schemas, that would work too.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working