Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show raw tags of quest objects #3815

Closed
hsimpson00 opened this issue Feb 27, 2022 · 5 comments
Closed

Show raw tags of quest objects #3815

hsimpson00 opened this issue Feb 27, 2022 · 5 comments
Labels
duplicate feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@hsimpson00
Copy link

In some complex situations the existing methods are not enough to figure out what object is actually meant.
For example if you are supposed to verify a tiket box in a big station, or you are asked by the foot-accessability of a small way in a complex crossing.

It would be helpful to pesent an option which allows you to see all the tags of the concerning object, so you can see the operator, the layer, level and more details to figure out where to look for the object. Maybe it would be even helpfull to see the relations the object is a member of.

@matkoniecz matkoniecz changed the title More details to objects Show raw tags of quest objects Feb 27, 2022
@matkoniecz
Copy link
Member

The problems here are that StreetComplete should be usable without ability to understand tags.

And full access to raw data is basically remaking Vespucci.

Can you mention quests where showing operator would be useful and this is not shown already?

@matkoniecz matkoniecz added the feedback required more info is needed, issue will be likely closed if it is not provided label Feb 27, 2022
@FloEdelmann
Copy link
Member

Related: #471 and many of the issues linked there (#1513, #1326, etc.)

@matkoniecz
Copy link
Member

matkoniecz commented Feb 27, 2022

I will close this one as duplicate of #471, #1513, #1326 but display of operator/ref is already supported in some quests and can be added to more if needed.

Feel free to comment here or open a new issue requesting specifically that if there is quest no displaying useful and present tags (check with object where this tag exist! When tags are not shown - maybe it is because OSM object is without them!).

If other tags are worth displaying and understandable without access to full OSM data - please also comment or open a new issue.

@FloEdelmann
Copy link
Member

FloEdelmann commented Feb 27, 2022

@peternewman
Copy link
Collaborator

peternewman commented Feb 27, 2022

And CheckExistence tries these:

override fun getTitle(tags: Map<String, String>): Int =
if (tags.containsAnyKey("name", "brand", "ref", "operator"))
R.string.quest_existence_name_title
else
R.string.quest_existence_title

So you'd need to give a real world example for a ticket vending machine to see what's going wrong there.

I agree footpaths/cycleways can be a bit confusing at times, especially as the latter are mapped the same as roads but that's been raised here streetcomplete/streetcomplete-mapstyle#94 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

4 participants