-
-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ask if steps/paths are indoors #3654
Comments
This would also make streetcomplete/streetcomplete-mapstyle#100 mostly redundant. And some of my frustration/confusion when being asked whether a separate ramp is mapped and I can't see it to know. |
Is there any chance a footway within a building outline is not going to be indoor? |
Yes, at the Barbican for example, all the walkways are underneath the tower blocks, but on columns, I think that's covered but not indoor: |
You mean arcades? |
Wouldn't that be a |
I think some could be arcades, some colonnades. I'm not really sure where something like the walkway on the left of this picture fits: Or: Also any mapped roof type structure (e.g. at a station) would cover a path but it wouldn't be indoors. Like the walkway at the front of this picture: |
I'll close this because this should rather be a maproulette task or validation. If an Checking for every single way segment whether it is inside a building outline is somewhat expensive to check when in 99.9% or more of cases this is irrelevant. Overall, streetcomplete is no linter/validator, there are other tools better suited for that. |
But how can you tell from satellite imagery (which is presumably what MapRoulette will give), whether it's indoors/covered/arcade/colonade/tunnel etc? You need to do an on the ground survey (using a tool like SC) or have StreetView style imagery to be able to answer that question.
Which is why I suggested the quest for both steps and paths.
I assume it would likewise be too expensive to do so for all the steps/path quests SC asks (even if cached so it's only checked once per way)?
Yeah I'd certainly agree pinning down whether it's indoors/covered/arcade/colonade/tunnel etc and getting consistent definitions for all of them could be a challenge.
Yep fair enough, although I feel like we've hit a bit of an impasse, please can we do something to fix it? I get asked about large numbers of paths/steps which are under the cover of a building (the exact type of cover is somewhat irrelevant); because streetcomplete/streetcomplete-mapstyle#100 is not available, I'm stuck with a Kim's game style memory challenge to try and identify the path/steps on the ground to answer the question. Could I suggest one of the following solutions:
Out of curiosity, why are indoor ways excluded anyway, just because of "Easily answerable by everyone from the outside but a survey is necessary"? Similar to a shopping mall, most of the quests I'm being asked are for stations and other high traffic public areas, so going inside is not a big imposition (indeed it's part of my planned route), although I appreciate there's no simple way to differentiate that from some other less well trafficked areas. Maybe it could be a second set of quests which are disabled by default? |
You can also open notes that it is a way missing an indoor tag or edit directly with Vespucci (for quests where indoor ways are excluded) If that happens often "can't say" option may be a good idea
For some quests indoor ways will have obvious answer or be inaccessible or both |
Yes, it does very much so, see for example the paths around/under/through these places (off the top of my head): A lot are tagged as tunnel at least, I guess you could get a bit philosophical about what's indoors...
I don't think the steps incline and some of the other quests are necessarily obvious, I appreciate they could be inaccessible, but hopefully the access tag filtering would cover that. |
@peternewman Which quests would benefit from that? |
General
Affected tag(s) to be modified/added: indoor
Question asked: Is this path indoors? Are these steps indoors?
Triggered by:
I hadn't even realised there was filtering for this as e.g. 90% of the recent stairs mapping I've done has been in tube (underground) stations which seemingly aren't tagged as indoor. Some are tagged as tunnel, some aren't tagged at all.
Checklist
Checklist for quest suggestions (see guidelines):
Ideas for implementation
Element selection:
All steps/paths under/within buildings
Proposed UI:
Simple Yes/No
The text was updated successfully, but these errors were encountered: