Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in calculating width and height in FFMpeg::Movie #207

Open
ndendi opened this issue Nov 6, 2019 · 2 comments
Open

Bug in calculating width and height in FFMpeg::Movie #207

ndendi opened this issue Nov 6, 2019 · 2 comments

Comments

@ndendi
Copy link

ndendi commented Nov 6, 2019

Typically rotation is set to null for many videos but sometimes it can be set to 0.
Rotation = 0 shouldn't swap the width and height in my opinion. This has caused problems by returning incorrect resolution for some of the videos we have.

I can send a fix for this if you agree this is an issue.
My fix is to add rotation == 0 check at
https://github.com/streamio/streamio-ffmpeg/blob/master/lib/ffmpeg/movie.rb#L159
@ndendi
Copy link
Author

ndendi commented Aug 19, 2020

Hello, commenting to bring this on top.

ndendi added a commit to ndendi/streamio-ffmpeg that referenced this issue Aug 19, 2020
@ndendi
Do not swap height and width when rotation is 0
fd1ee4e 
streamio#207
@ndendi ndendi mentioned this issue Aug 19, 2020
Open
@marcoadkins
Copy link

Bumping this as I am having the same issue currently with a few videos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcoadkins @ndendi