Merge pull request #214 from stygmate/main

make pk argument required when querying single object

Author: bellini666

strawberry_django/filters.py

@@ -182,7 +182,7 @@ def arguments(self) -> List[StrawberryArgument]:
             filters = self.get_filters()
             if self.django_model and not self.is_list:
                 if self.is_relation is False:
-                    arguments.append(argument("pk", strawberry.ID))
+                    arguments.append(argument("pk", strawberry.ID, is_optional=False))
             elif filters and filters is not UNSET:
                 arguments.append(argument("filters", filters))
         return super().arguments + arguments

tests/test_queries.py

@@ -2,6 +2,7 @@
 
 import pytest
 import strawberry
+from graphql import GraphQLError
 from strawberry import auto
 
 import strawberry_django
@@ -82,6 +83,18 @@ async def test_single(query, users):
     assert result.data["user"] == {"name": users[0].name}
 
 
+async def test_required_pk_single(query, users):
+    result = await query("{ user { name } }")
+
+    assert bool(result.errors)
+    assert len(result.errors) == 1
+    assert isinstance(result.errors[0], GraphQLError)
+    assert (
+        result.errors[0].message == "Field 'user' argument 'pk' of type 'ID!' is "
+        "required, but it was not provided."
+    )
+
+
 async def test_many(query, users):
     result = await query("{ users { name } }")