Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize StoppedPool property interface in next D-Bus interface revision #3153

Open
jbaublitz opened this issue Nov 1, 2022 · 1 comment
Open

Standardize StoppedPool property interface in next D-Bus interface revision #3153

jbaublitz opened this issue Nov 1, 2022 · 1 comment
Assignees
@jbaublitz

Comments

@jbaublitz
Copy link
Member

jbaublitz commented Nov 1, 2022 •
edited
Loading

Currently we have a tuple indicating whether a key description and clevis information is set for LockedPools, but for StoppedPools this tuple is always (true, String) because we don't set it if the pool is not encrypted. We should standardize on one or the other (either a tuple or presence/absence).
@jbaublitz jbaublitz self-assigned this Nov 1, 2022
@jbaublitz jbaublitz mentioned this issue Nov 1, 2022
Merged
@jbaublitz jbaublitz changed the title Standardize StoppedPool property interface in v4.0.0 Standardize StoppedPool property interface in next D-Bus interface revision Nov 1, 2022
@jbaublitz
Copy link
Member Author

@bmr-cymru @mulkieran Would you prefer a tuple or an absent key-value pair?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbaublitz jbaublitz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbaublitz