Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Fails when trying to package binary imports #64

Open
OiYouYeahYou opened this issue Oct 15, 2024 · 0 comments
Open

[bug]: Fails when trying to package binary imports #64

OiYouYeahYou opened this issue Oct 15, 2024 · 0 comments
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around

Comments

@OiYouYeahYou
Copy link

What version of @strapi/sdk-plugin are you using?

npm: 10.8.3
node: ^20
sdk: 5.2.7
browser: n/a

What's Wrong?

pack-up via sdk-plugin does not support binary imports like the one used in @ngrok/ngrok. 'sdk-pluginprovides no way to add bundlers and negates the ability to usepackup.config.jsby usingdisableConfig: falsewhen calling eitherwatchorbuild`.

To Reproduce

  1. Create a new plugin with server features
  2. Install @ngrok/ngrok which depends on an arch dependent dep with a .node binary
  3. Import this into a server file
  4. Running either watch or build will fail, as the tools only expect plaintext JS

Expected Behaviour

Allow developers to use binaries by either:

  1. Provide the ability to extend pack-up with extra bundlers
  2. Include the ability to import .node binaries by default
@OiYouYeahYou OiYouYeahYou added the issue: bug Issue reporting a bug label Oct 15, 2024
@innerdvations innerdvations added the severity: medium If it breaks the basic use of the product but can be worked around label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug severity: medium If it breaks the basic use of the product but can be worked around
Projects
None yet
Development

No branches or pull requests

2 participants