Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Use css color-scheme to improve dark theme #947

Open
alexandrebodin opened this issue Apr 5, 2023 · 0 comments
Open

[feat]: Use css color-scheme to improve dark theme #947

alexandrebodin opened this issue Apr 5, 2023 · 0 comments
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package

Comments

@alexandrebodin
Copy link
Member

alexandrebodin commented Apr 5, 2023

A clear and concise description of what the feature is

The css color-scheme property allows to set some native browser features as dark or light themed when supported.

Why should this feature be included?

The usecase I came across is the Chrome scrollbar.

It is obvisouly not as perfect as designing custom things but that works much better than having the light scroll in our dark theme for almost no cost.

It might be something we can set directly in the product rather than in the DS but putting it outhere to open the discussion and see if there are drawbacks to doing it.

Please provide an example for how this would work

color-scheme: dark;
@alexandrebodin alexandrebodin added the issue: enhancement Issue suggesting an enhancement to an existing feature label Apr 5, 2023
@joshuaellis joshuaellis added the source: design-system relates to design-system package label May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: design-system relates to design-system package
Projects
None yet
Development

No branches or pull requests

2 participants