Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<DatePicker /> component autoComplete issue #1798

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

<DatePicker /> component autoComplete issue #1798

wants to merge 2 commits into from

Conversation

alexandermirzoyan
Copy link

What does it do?

Added autoComplete="off" prop to <DatePicker /> component by default.

Why is it needed?

Fixes issue with browser's default behaviour.

How to test it?

Make sure that you have some suggestions from the browser and click on input tag from the <DatePicker /> component.

Related issue(s)/PR(s)

#1797

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9a23178

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 9:46am

@hanpaine
Copy link
Contributor

Hey @alexandermirzoyan thanks for your contribution. We've migrated to the DS v2 now; can you verify if you're still seeing the issue please as the PR is currently pointed at our v2 (v1 is maintained on branch /v1 and only High and Criticals are supported there right now). Cheers!

@hanpaine hanpaine added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Oct 11, 2024
@alexandermirzoyan
Copy link
Author

Am I correct that DS v2 is working with Strapi's v5?

@remidej
Copy link
Contributor

remidej commented Oct 30, 2024

@alexandermirzoyan yes Strapi 5 uses the latest design system v2 RC

@Marc-Roig
Copy link

@alexandermirzoyan thank you for the contribution! As a final step, could you update the changeset?

We use this mechanism to keep track of all changes, you can see the docs here

you can see an example of how we update it

@markkaylor
Copy link
Contributor

markkaylor commented Nov 26, 2024 •
edited
Loading

@alexandermirzoyan if you have a second to add a changeset looks like we can merge 🚀

Let us know if anything isn't clear in the doc for adding the changeset

@markkaylor markkaylor linked an issue Nov 26, 2024 that may be closed by this pull request
[bug]: <DatePicker /> component autoComplete prop #1797
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marc-Roig Marc-Roig Marc-Roig approved these changes

Assignees

@Marc-Roig Marc-Roig

Labels
community pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: <DatePicker /> component autoComplete prop
6 participants
@alexandermirzoyan @hanpaine @remidej @Marc-Roig @markkaylor @oiorain