fixed deselection of notes on note-move

hey man

Author: strangewarp

CHANGELOG.txt

@@ -7,10 +7,6 @@
 
 1.1
 
--- TODO: Fix deselection of notes on note-move.
-
--- TODO: Fix badly-sized notes on undo-after-mod-duration.
-
 -- TODO: Remove unnecessary 'undo-suppression' vars from function-calls and undo-funcs.
 
 -- TODO: Test all commands again, especially Entry-Quantize, to check for bugs caused by refactoring / new features.
@@ -60,6 +56,7 @@
 -- Changed the rendering properties of the notes within a sequence's non-active channels, both in their default state and while selected.
 
 * Logic changes:
+-- Fixed deselection of notes on note-move.
 -- Fixed a nasty bug in removeSequence that was incurred by changes in modNotes. Also added setTicks and removed several outdated functions in the process.
 -- Decoupled modSelectedNotes commands from spacing. They now stick to beat-factor horizontally, and have 1-and-12-spaced variants vertically.
 -- Stopped keyboard-notes from incurring new undo-blocks when not in Record Mode.

funcs/modify-funcs.lua

@@ -52,6 +52,7 @@ return {
 	modNotes = function(p, ntab, isselect, multiply, undo)
 
 		local snotes = {}
+		local renewnotes = {}
 
 		-- For every note, in order, add the mod-command's results to the snotes table
 		for nk, ntab in ipairs(ntab) do
@@ -68,10 +69,10 @@ return {
 				table.insert(snotes, {'remove', n})
 				table.insert(snotes, {'insert', m})
 
-				-- Unset the note's old selection-data entry, and build a new entry reflecting its changes
+				-- Unset the note's old selection-data entry, and build a new temp-entry reflecting its changes
 				if isselect then
 					copyUnsetCascade('seldat', n)
-					buildTable(D.seldat, {m[2] + 1, m[4], m[5]}, m)
+					table.insert(renewnotes, m)
 				end
 
 			end
@@ -81,6 +82,13 @@ return {
 		-- Call setNotes for all tabbed modifications
 		setNotes(p, snotes, undo)
 
+		-- If there was a selection, rebuild the selection-table from the accurate temp-entries
+		if isselect then
+			for k, v in pairs(renewnotes) do
+				buildTable(D.seldat, {v[2] + 1, v[4], v[5]}, v)
+			end
+		end
+
 	end,
 
 	-- Take a note, modify a given byte within that note by a given amount, and return it