Commit e1e9336
committed
feat: add session tracking and cleanup for AgentCoreBrowser
Implement proper session lifecycle management for browser instances:
Code changes:
- Add _client_dict to track active browser sessions by session_id
- Populate _client_dict in create_browser_session() for session tracking
- Register atexit handler in __init__() to ensure cleanup on process exit
- Ensures browser sessions are properly closed when process terminates
Tests:
- test_bedrock_browser_create_browser_session_hydrates_client_dict:
Verifies _client_dict is populated when sessions are created
- test_bedrock_browser_registers_atexit_handler:
Confirms cleanup handler is registered at initialization
This prevents resource leaks from orphaned browser sessions and ensures
all active sessions are tracked and cleaned up properly.1 parent 8064644 commit e1e9336
File tree
2 files changed
+53
-1
lines changed- src/strands_tools/browser
- tests/browser
2 files changed
+53
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| 40 | + | |
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| |||
49 | 51 | | |
50 | 52 | | |
51 | 53 | | |
| 54 | + | |
52 | 55 | | |
53 | 56 | | |
54 | 57 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
20 | 35 | | |
21 | 36 | | |
22 | 37 | | |
| |||
58 | 73 | | |
59 | 74 | | |
60 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
61 | 110 | | |
62 | 111 | | |
63 | 112 | | |
| |||
0 commit comments