Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to resolve "@storybook/core/manager-api" #628

Open
pvinis opened this issue Oct 22, 2024 · 14 comments
Open

Unable to resolve "@storybook/core/manager-api" #628

pvinis opened this issue Oct 22, 2024 · 14 comments

Comments

@pvinis
Copy link
Contributor

pvinis commented Oct 22, 2024

Describe the bug
I am trying to add storybook on an expo 51 project with expo-router.

To Reproduce
Steps to reproduce the behavior:

  1. I have added the withStorybook in metro.config.js
  2. I have added the require().default bit on my index.tsx
  3. When I start without the storybook_enabled envvar, I get this error:
Unable to resolve "@storybook/core/manager-api"

I'll try to make a repro tomorrow, with 8.3.10.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
Image

Code snippets
If applicable, add code samples to help explain your problem.

System:
Please paste the results of npx -p @storybook/cli@next sb info here.

Additional context
Add any other context about the problem here.

@dannyhw
Copy link
Member

dannyhw commented Oct 22, 2024

Can you make sure that when storybook enabled is false that storybook isnt being loaded by app code (conditionally require it when enabled is true)

You can also try onDisabledRemoveStorybook set to true on the latest version.

Lastly clearing cache can sometimes be required after changing env variables

Alternatively change package exports to true in metro config

@alvinlal
Copy link

alvinlal commented Oct 25, 2024

Can you make sure that when storybook enabled is false that storybook isnt being loaded by app code (conditionally require it when enabled is true)

You can also try onDisabledRemoveStorybook set to true on the latest version.

Lastly clearing cache can sometimes be required after changing env variables

Alternatively change package exports to true in metro config

@dannyhw i am also facing the same issue,

  1. made sure storybook isn't being loaded by app code ✅
  2. where to set onDisabledRemoveStorybook to true ? 🤔
  3. tried clearing cache ✅
  4. can't see a metro config since i am using expo 🤔

thanks

@dannyhw
Copy link
Member

dannyhw commented Oct 25, 2024

You need to create a metro config file its required in the setup (see readme).

npx expo customize metro.config.js

See getting started

https://github.com/storybookjs/react-native#getting-started

@alvinlal
Copy link

You need to create a metro config file its required in the setup (see readme).

npx expo customize metro.config.js

See getting started

https://github.com/storybookjs/react-native#getting-started

thanks @dannyhw , i got it working perfectly

@iamdin
Copy link

iamdin commented Oct 28, 2024

Hi, @dannyhw I also face the same issue, and i am using expo@46 and ReactNative@69.
Here is the minimum reproducible repository: https://github.com/iamdin/react-native-69-storybook

@dannyhw
Copy link
Member

dannyhw commented Oct 28, 2024

Are you using the storybook commands to run the app? The env variable is being used in your repro.

@dannyhw
Copy link
Member

dannyhw commented Oct 28, 2024

@iamdin seems like the older version doesn't support package exports in metro maybe? the package exports option is required in v8

I highly recommend updating expo/rn in your project.

@dannyhw
Copy link
Member

dannyhw commented Oct 28, 2024

react native 0.72 would be a minimum, just based on this https://reactnative.dev/blog/2023/06/21/package-exports-support

I can't really do anything about that either since storybook core heavily uses package exports to define the entry points for storybook packages.

probably the options are stay on storybook 7 or upgrade expo/rn

expo 49 has 0.72 btw

@iamdin
Copy link

iamdin commented Oct 30, 2024

@dannyhw Thank you very much for your time & answer. I indeed used storybook commands to run the app. Unfortunately, When i upgrade to expo49 with RN 0.72, got some file resolution errors. I update the codebase https://github.com/iamdin/react-native-69-storybook
Image
By the way, before i used storybook in react-native, i checked the version requirement

"react-native": ">=0.57.0",

@dannyhw
Copy link
Member

dannyhw commented Oct 30, 2024

I will update the peer dep thing because its out of date, sorry about that.

What if you set defaultConfig.resolver.unstable_enablePackageExports = true manually in your metro config

@dannyhw
Copy link
Member

dannyhw commented Oct 30, 2024

also try defaultConfig.resolver.sourceExts.push('mjs');

Mjs was added by default in I think maybe expo 50

I mean of course if you can then just upgrade all the way to expo 51

@Fab-Diaz
Copy link

Fab-Diaz commented Nov 6, 2024

Hi! I'm using expo 51 and the latest storybook version (8.3.10) and unfortunately come across the same issue. Reverting it back to v.7 fixes it, but we might have to wait for a patch?

@dannyhw
Copy link
Member

dannyhw commented Nov 6, 2024

@Fab-Diaz you need to use the withStorybook metro config function, can you make sure you have followed the migration steps carefully.

@shintiazhou
Copy link

shintiazhou commented Nov 11, 2024

@Fab-Diaz @pvinis Try removing storybook from the bundle, it seems to fix the issue for me!

// metro.config.js
metroConfig.resolver.resolveRequest = (context, moduleName, platform) => {
  const defaultResolveResult = context.resolveRequest(context, moduleName, platform);

  if (
    process.env.STORYBOOK_ENABLED !== 'true' &&
    defaultResolveResult?.filePath?.includes?.('.storybook/')
  ) {
    return {
      type: 'empty',
    };
  }

  return defaultResolveResult;
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants