-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StoryblokComponent vs component #142
Comments
Hi @m0zz094 thanks for this issue! I'm curious about this, because StoryblokComponent is a basic wrapper of Have you investigated this further? |
@manuelschroederdev keeping you on the loop |
Hi @alexjoverm, I haven't investigated this further, but if you need more context here's what I'm doing on [...slug].vue `<script setup> story = data.value.data.story; |
Hey @m0zz094, could you possibly provide a link to your complete project on GitHub or StackBlitz? That would make it a little easier for us to debug the issue. Thanks. 😊 |
I've create two different versions of a demo project, one using the StoryblokComponent, one using the default component. I've uploaded them to Vercel and couldn't identify any notable performance differences. https://storyblok-components-test.vercel.app Are you still encountering these issues? |
If you look at the page source on the the two links, there is a big difference, the https://storyblok-components-test.vercel.app/ does not generate the static markup and https://components-test-inky.vercel.app/ does.. Maybe there is a bug in StoryblokComponent? |
I'm also experiencing the issue with the StoryblokComponent. Here's a comparison of the markup generated for the two test sites @manuelschroederdev set up with Javascript disabled. Notice that the component markup is only generated on https://components-test-inky.vercel.app/ |
Thank you very much for pointing this out, @Lauritzz77 and @caroillemann. We will investigate this further and get back to you as soon as possible. |
Hi, @m0zz094 do you know if this is still an issue? @manuelschroederdev @Dawntraoz any update from our side? |
Hi @alvarosabu, I haven't changed my codebase since then honestly, I'm still using the component approach for now |
As per the abovementioned issue, this behavior was fixed from v4.x.x -> #204 (comment). Can you @m0zz094 replace your solution with |
Any updates @m0zz094? |
I get huge performance issues when using the StoryblokComponent instead of component:
example using component: https://family-business-unit-f0hhivfwp-cloudnova-srl.vercel.app/
example using StoryblokComponent: https://family-business-unit-6nuzynxzr-cloudnova-srl.vercel.app/
The text was updated successfully, but these errors were encountered: