-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ALL the registered bloks are loaded on the client even when not used on the current page #886
Comments
I'm seeing the same thing, even on deployed sites I'd put this high on the priority list as it could definitely effect performance and cause had to debug issues. |
After looking into this more it looks like this is expected behaviour from Astro. any script tags are automatically hoisted and loaded as JS modules. A workaround if this causes issues I guess is to have the script inline or add attributes to the script tag. |
@manuelschroederdev This is a huge flaw of the astro integration, it should be prioritized don't you think so? |
@Dav3rs , Thank you for bringing this issue to our attention. We're actively investigating it and will keep you updated with our findings. If we identify any workarounds or solutions, we’ll share them with you here and document them for other users as well. |
There’s no way to integrate dynamic components without a change in how Astro changes their build process. Related discussion: withastro/astro#4863 |
We have opened an issue quite a while ago that is discussing the exact same problem. Just to get everyone on the same page: withastro/astro#4863 (comment) And I still think it is a crucial thing, especially when working with a CMS. |
Sorry @markpinero, I just saw that you were referring to it already. |
Hi everyone! I've started a discussion about tree-shaking unnecessary components for static builds with CMS page builders here: withastro/roadmap#1054 Would love to hear your thoughts! My knowledge is clearly limited, so please weigh in. |
Describe the issue you're facing
I notice that my page was crashing due to scripts being executed that have nothing to do with the current page content.
It looks that ALL the storyblok components registered in the project are sent to client even when they are not needed in the current page consumed stories.
For example
1- I create a component that is not used on the page
2- With the next content
3- It it loaded 🫤
Reproduction
https://stackblitz.com/~/github.com/Dav3rs/astro-storyblok
Steps to reproduce
No response
System Info
Used Package Manager
npm
Error logs (Optional)
No response
Validations
The text was updated successfully, but these errors were encountered: