Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware-level testing of rate limits and auth tokens #141

Closed
Tracked by #136
travis opened this issue Sep 20, 2024 · 3 comments
Closed
Tracked by #136

Middleware-level testing of rate limits and auth tokens #141

travis opened this issue Sep 20, 2024 · 3 comments
Assignees

Comments

@travis
Copy link
Member

travis commented Sep 20, 2024

We should add some middleware or service-level tests to ensure that the new rate limit and auth token functionality doesn't regress.

We have some short term goals and some medium term ones - it would be nice to at least sketch out some of the medium term goals in testing, even if we keep those tests disabled for now. For example, we definitely need a test that shows that once a user has created an auth token they are able to access a resource with no rate limit, but we should probably also have one that shows that an invalid delegation should not result in access to a resource, but our current iteration may not have any concept of delegations, instead simply tracking auth tokens in a table we control.

Put another way, I'd like this issue to capture putting some integration testing into place now and laying some rails for the evolution of this project toward a more decentralized design.

@fforbeck
Copy link
Member

@fforbeck
Copy link
Member

fforbeck commented Oct 3, 2024

@fforbeck fforbeck self-assigned this Oct 3, 2024
@fforbeck fforbeck moved this from Sprint Backlog to In Progress in Storacha Project Planning Oct 7, 2024
@fforbeck
Copy link
Member

fforbeck commented Oct 7, 2024

Integration & Unit tests setup implemented and added as part of the GitHub Test workflow.
We still don't have the concept of Delegations in the Freeway project, so the tests are considering simple Bearer Authentication tokens to test the rate-limit strategy.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Storacha Project Planning Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants