Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support verifiable CAR responses #32

Closed
olizilla opened this issue Apr 12, 2023 · 1 comment
Closed

Support verifiable CAR responses #32

olizilla opened this issue Apr 12, 2023 · 1 comment

Comments

@olizilla
Copy link
Contributor

olizilla commented Apr 12, 2023

return a CAR that is verifiable. This means that the CAR will contain all blocks required to verify the root CID and any additional path traversals to the requested content. It should always be possible to verify the root block content against the requested CID, and every block that is traversed to reach the content as specified by the final path.
https://github.com/filecoin-project/lassie/blob/main/docs/CAR.md

So for a request GET /ipfs/<cid1>/a/b/cat.gif we should return the blocks for

  • <cid1>
  • a
  • b
  • all blocks for cat.gif

currently we return "all blocks for cat.gif" which is nice but does not include enough information to verify that the blocks for the cat gif are the ones you would get if you had traversed the dag from yourself. By returning the minimal set of blocks traversed from the root cid in the request path, the caller will have all the bytes they need to verify the path traversal was done correctly.

### Tasks
- [ ] https://github.com/web3-storage/dagula/pull/8
- [ ] https://github.com/web3-storage/gateway-lib/pull/21
- [ ] https://github.com/web3-storage/dagula/pull/17
- [ ] https://github.com/web3-storage/dagula/pull/7
- [x] update freeway
- [x] deploy freeway
olizilla added a commit to storacha/dagula that referenced this issue Apr 12, 2023
This will allows us to export verifiable CAR for cid+path requests

see: storacha/freeway#32

License: MIT
Signed-off-by: Oli Evans <[email protected]>
olizilla added a commit to storacha/dagula that referenced this issue Apr 17, 2023
This will allows us to export verifiable CAR for cid+path requests

see: storacha/freeway#32

License: MIT

Signed-off-by: Oli Evans <[email protected]>
@olizilla
Copy link
Contributor Author

olizilla commented May 3, 2023

Completed in #35
Deployed as #36

@olizilla olizilla closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant