-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove the postfix License after the license name in AdditionalInfo #2573
Conversation
✅ Deploy Preview for stoplight-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I don't know the team philosophy when the data doesn't match the OpenAPI spec. You could not display at all if the strict terms "mutually exclusive" aren't followed ( https://spec.openapis.org/oas/v3.1.0#license-object ) ; or you could error. Probably should follow whatever's your convention. There's not a test case for "name" alone. Only name is required and if name alone is there, then it seems to me it it should be just the name text. You don't want to get "undefined" as the link. |
@kentbulza Thanks, I have updated it |
We do like this approach for fixing the postfix, but our team needs to do additional testing prior to merging this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Can we merge it? ❤️ |
@weyert Can we fix the tests please and then we should be good to merge! |
@mnaumanali94 I have updated the tests |
The end to end tests are funning for me locally. Not sure what's up with the CI
|
Elements Default PR Template
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
CONTRIBUTING.md
This pull request changes the way the license name gets rendered in
HttpService
and should fix #2523