Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 Feature: Truncate Long Share Links #479

Open
fmunim opened this issue May 22, 2024 · 3 comments
Open

馃殌 Feature: Truncate Long Share Links #479

fmunim opened this issue May 22, 2024 · 3 comments
Labels
feature New feature or request

Comments

@fmunim
Copy link

fmunim commented May 22, 2024

馃敄 Feature description

Truncate the shares for Directly sharing and the share page to a shorter url

馃帳 Pitch

Currently the direct share link and regular share link:

Direct Share: https://domain/api/shares/Q5MTUyN/files/4ecb4db0-2993-481a-84ab-5932d99a8151?download=false
Regular Share: https://domain/s/Q5MTUyN

Is too long!

It should be just:

Direct Share: https://domin/D-XXRandomStringXX
Regular Share: https://domain/XXRandomStringXX

@fmunim fmunim added the feature New feature or request label May 22, 2024
@fmunim fmunim changed the title 馃殌 Feature: Clean Up Direct Share Links 馃殌 Feature: Truncate Long Share Links May 22, 2024
@fmunim
Copy link
Author

fmunim commented Jun 25, 2024

@stonith404 Any update on this or any comments?

@stonith404
Copy link
Owner

Yeah file links are definitely too long. Nevertheless this isn't really something that I want to prioritize as it's not really intended to share file links directly. Additionally, implementing this this would require significant effort as it would involve revising the database structure. As a workaround, you could use a self-hosted URL shortener like Shlink.

But I'm open if someone wants to contribute to this feature :)

Regarding share links, what would you suggest to make it shorter? The /s/ can't really be omitted as the share id could then collide with website paths. For example, if you create a share with the id upload, it won't be accessible as http://domain/upload is already a page. Or do you have another suggestion?

@fmunim
Copy link
Author

fmunim commented Jun 29, 2024

Yeah file links are definitely too long. Nevertheless this isn't really something that I want to prioritize as it's not really intended to share file links directly. Additionally, implementing this this would require significant effort as it would involve revising the database structure. As a workaround, you could use a self-hosted URL shortener like Shlink.

But I'm open if someone wants to contribute to this feature :)

Regarding share links, what would you suggest to make it shorter? The /s/ can't really be omitted as the share id could then collide with website paths. For example, if you create a share with the id upload, it won't be accessible as http://domain/upload is already a page. Or do you have another suggestion?

Funnily I already use shrink because the direct URL is too long >.<, but I understand.

For short share links---isn't share ids just random characters? maybe you can enforce that to deter collision?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants