Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simpleStream.nextEvents() Allocates new bytes slice on each call to read json #78

Open
server-may-cry opened this issue Sep 12, 2021 · 0 comments · May be fixed by #79
Open

simpleStream.nextEvents() Allocates new bytes slice on each call to read json #78

server-may-cry opened this issue Sep 12, 2021 · 0 comments · May be fixed by #79

Comments

@server-may-cry
Copy link

server-may-cry commented Sep 12, 2021 •
edited
Loading

Simple stream allocates new slice of bytes on each call to read json line. This allocation became significant when simple_stream reads big json faster than GC frees memory.

go-nakadi/simple_stream.go

Line 87 in 1a6ca9f

func (s *simpleStream) nextEvents() (Cursor, []byte, error) {

@server-may-cry server-may-cry linked a pull request Sep 12, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reuse bytes for line read server-may-cry/go-nakadi
1 participant
@server-may-cry