Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Processor is unable to stop stream immediately #42

Open
krnkl opened this issue Jul 13, 2018 · 1 comment
Open

Processor is unable to stop stream immediately #42

krnkl opened this issue Jul 13, 2018 · 1 comment

Comments

@krnkl
Copy link
Collaborator

krnkl commented Jul 13, 2018

When Processor start stream it blocks on call to stream.NextEvents here until any event arrives. This method doesn’t return on keep-alive messages.

When Processor.Stop() is called it cancels Processor.ctx and waits for a all started streams to be finished.
However, there is no way this cancellation triggers anything inside single stream. Thus, until any real event arrives on nakadi - stream will block.

As implications:
• processor cannot stop all streams immediately
• processor cannot stop stream until other event than keep-alive is sent

@buzzlighty
Copy link

@krnkl Were you able to find a workaround to stop it gracefully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants