Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding starttime and endtime parameters to Dynam-i #33

Open
marion-hoffman opened this issue May 2, 2021 · 1 comment
Open

Adding starttime and endtime parameters to Dynam-i #33

marion-hoffman opened this issue May 2, 2021 · 1 comment
Assignees
Labels
Difficulty: Trivial Expected workload is less than a week. Status: In Progress Assigned developer is working on addressing the issue. Type: Bug Issue is about an error in existing code that needs fixing.

Comments

@marion-hoffman
Copy link
Collaborator

When creating windowed events, some right-censored events are added after the last dependent events. It would be better to remove them. This is true for all rate models.

I propose to just erase the extra rows ahen the windowed events are created, before preprocessing. I'll do this on the DyNAM-i branch for now and it can be added to the main if it works fine (@auzaheta you can check then if that's ok with you).

@marion-hoffman marion-hoffman added Type: Bug Issue is about an error in existing code that needs fixing. Difficulty: Trivial Expected workload is less than a week. Status: In Progress Assigned developer is working on addressing the issue. labels May 2, 2021
@marion-hoffman marion-hoffman self-assigned this May 2, 2021
@marion-hoffman
Copy link
Collaborator Author

--> Correction: this can be done through the starttime and endtime parameters, which is not available yet for dynam-i, which I will correct (title changed).

@marion-hoffman marion-hoffman changed the title Right-censored events after the end of dependent events hould be removed Adding starttime and endtime parameters to Dynam-i May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Trivial Expected workload is less than a week. Status: In Progress Assigned developer is working on addressing the issue. Type: Bug Issue is about an error in existing code that needs fixing.
Projects
None yet
Development

No branches or pull requests

1 participant