Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely detached hose keeps leaking slurry #54

Open
Timmiej93 opened this issue Mar 14, 2018 · 5 comments
Open

Completely detached hose keeps leaking slurry #54

Timmiej93 opened this issue Mar 14, 2018 · 5 comments
Assignees
Labels

Comments

@Timmiej93
Copy link

The hose in the screenshot was connected to both the FRC and the slurry tank. I first disconnected the slurry tank side by driving away, hose started leaking as expected. I then drove the FRC away, the hose disconnected from it as well, but it kept the slurry leaking animation active indefinitely.

This test was done on the current ModHub version 1.1.0.0, on Goldcrest Valley.

fsscreen_2018_03_14_10_32_11

@Timmiej93 Timmiej93 changed the title Detached hose keeps leaking slurry Completely detached hose keeps leaking slurry Mar 14, 2018
@stijnwop
Copy link
Owner

Did you detach it yourself or did it detach while driving away?

@Timmiej93
Copy link
Author

The hose was detached on both sides by driving the implements away. The slurry tanker side was detached first, the FRC second.

@stijnwop
Copy link
Owner

I believe to have noticed the same situation when driving the implements away.. will try to confirm this issue.

Thanks for your report. ;)

@stijnwop
Copy link
Owner

This only happens when driving away when the other side of the hose is stuck behind something (like an object) right? Not when it's attached to another vehicle.

Then i might need to add a check on:

self.attachedHoseSystemReferences[referenceId] = nil

If the current effect is still visible then force it to stop and set update bit.

@Timmiej93
Copy link
Author

I have only experienced this when driving away, with the hose not attached on one side, manure flow open, and the hose then falling off. The manure does stop draining from the container.

It's hard to say for sure without having read up a bit on your code, but I think that your solution should work.

@stijnwop stijnwop self-assigned this Mar 22, 2018
@stijnwop stijnwop added the bug label Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants