Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frames incompatible with ASE functions #64

Open
ElliottKasoar opened this issue Apr 20, 2023 · 0 comments
Open

Frames incompatible with ASE functions #64

ElliottKasoar opened this issue Apr 20, 2023 · 0 comments
Labels

Comments

@ElliottKasoar
Copy link
Member

ElliottKasoar commented Apr 20, 2023

Frames inherit from ASE's Atoms class, but due to differences in attributes, many functions unexpectedly break.

For example, attempting to print a single Frame raises AttributeError: 'numpy.ndarray' object has no attribute 'get_chemical_formula'.

Errors also occur when attempting to calculate distances between Frames using ase.geometry.distance, as this calls atoms.copy(), which raises TypeError: __init__() got an unexpected keyword argument 'cell'.

Unexpected arguments could be fixed by adding **kwargs, but Frame currently also requires arguments that would be missing.

The same error (AttributeError: 'numpy.ndarray' object has no attribute 'formula') is also thrown when attempting to write a .cif file through Dataset.write.

@alinelena alinelena added the janus label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants