Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better version compatibility with JWT 3.4.6 #50

Open
mattsah opened this issue Nov 30, 2022 · 2 comments
Open

Better version compatibility with JWT 3.4.6 #50

mattsah opened this issue Nov 30, 2022 · 2 comments

Comments

@mattsah
Copy link

mattsah commented Nov 30, 2022

Hello,

The project suggests it will work with lower versions of PHP, however, cannot because of JWT 4.1.5 requirement. I believe JWT 3.4.6 is not only an API compatibility layer with 4.x but also has requisite security fixes applied that were applied to 4.1.5. Would it be possible to add 3.4.6 explicitly to the versions of JWT allowed?

@mattsah
Copy link
Author

mattsah commented Nov 30, 2022

I should add that despite the compatibility changes, this would require a reversion in the IdTokenResponse class to sniff out the available builder. This was previously done here: 6c66644

I've got a fork of this currently under a totally different package name which has re-employed some of this: master...imarc:oauth2-openid-connect-server:master

@stof
Copy link
Contributor

stof commented Sep 30, 2024

@steverhoades as support for old PHP versions has been officially dropped in 3.0, I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants