Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-caching of delta_x can lead to weird results #17

Open
steven-murray opened this issue Dec 1, 2022 · 1 comment
Open

Non-caching of delta_x can lead to weird results #17

steven-murray opened this issue Dec 1, 2022 · 1 comment
Assignees
@steven-murray
Labels
enhancement

Comments

@steven-murray
Copy link
Owner

Since we don't cache the result of delta_x(), when comparing the output of create_discrete_sample() with delta_x(), it'll be wrong unless you set the seed. We could cache the box, or allow inputting the box itself to create_discrete_sample().
@steven-murray steven-murray self-assigned this Dec 1, 2022
@steven-murray
Copy link
Owner Author

Keyword passing implemented in #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@steven-murray steven-murray

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@steven-murray