Major cppcheck driven code cleanup coming today

[caryr]

Over the last few days I have been working on a significant cleanup of the code to get it as clean as possible with cppcheck. Some of it is just convention and dead code issues, but I have uncovered a few cases that were/are real bugs (e.g code that would break if assertions were turned off and one case of the begin and end iterators using different collection). I hope to have what I have done so far reviewed a second time and pushed, but know I have touched a huge number of files so there is a possibility of conflicts. There are still a few remaining issues that I need to look at next, but I want to get all the change I have done so far in soon to minimize disruption.

[caryr]

All the changes I have made so far have been pushed.

[caryr]

Closing since this has been completed.