Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP_CodeSniffer for checking coding standards #45

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

stevegrunwell
Copy link
Owner

This PR introduces PHP_CodeSniffer with the PHPCompatibility ruleset, used to verify that everything aligns to PSR-12 and is compatible with our minimum PHP version (currently 5.6).

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling e7559b6 on feature/phpcs
into 8feaae5 on develop.

@stevegrunwell stevegrunwell merged commit 3d17b2a into develop Dec 3, 2023
14 checks passed
@stevegrunwell stevegrunwell deleted the feature/phpcs branch December 3, 2023 22:05
@@ -20,6 +20,9 @@
"symfony/dom-crawler": "^3.4|^4.4|^5.4|^6.0"
},
"require-dev": {
"dealerdirect/phpcodesniffer-composer-installer": "^1.0",
"phpcompatibility/php-compatibility": "^9.3",
"phpcsstandards/php_codesniffer": "^3.7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"phpcsstandards/php_codesniffer": "^3.7",
"squizlabs/php_codesniffer": "^3.7",

Thank you for your support and your enthousiasm embracing the take-over of the PHP_CodeSniffer package.

In contrast to earlier information, arrangements are now being made to allow the package to continue under its original name on Packagist. The commit (in the new repo) to rename the package has been reverted.

Sorry for the confusion and thank you for understanding. I hope you'll enjoy the 3.8.0 release, which I expect to release this Friday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants