Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ELBO calculation in the presence of missing data #7

Open
gaow opened this issue Nov 18, 2019 · 2 comments
Open

ELBO calculation in the presence of missing data #7

gaow opened this issue Nov 18, 2019 · 2 comments

Comments

@gaow
Copy link
Member

gaow commented Nov 18, 2019

This is only problematic for EZ model alpha=1 not for EE model alpha=0. Here is the data-set and notebook that reproduces the problem. In the notebook I've also done some initial diagnosis.

issue_6.tar.gz

Notice that here Y has missing data. But I doubt it is problem with missing data because the residual variance I use here is diagonal.

@gaow gaow changed the title Non-increasing elbo in EZ model Decreasing elbo in EZ model Nov 18, 2019
@gaow
Copy link
Member Author

gaow commented Nov 18, 2019

But I doubt it is problem with missing data because the residual variance I use here is diagonal.

Another place missing data will have an impact is the quantity XtX and occurs precisely only in the code that computes ELBO:

https://github.com/gaow/mmbr/blob/master/R/susie_regression.R#L129

So ELBO computation in the presence of missing data should be rederived.

@gaow gaow changed the title Decreasing elbo in EZ model ELBO calculation in the presence of missing data Nov 19, 2019
@gaow
Copy link
Member Author

gaow commented Dec 6, 2019

For the time being I added a warning message here:

https://github.com/gaow/mmbr/blob/f2a2cf3df719dd1725b13b61525006e7b8bf20b1/R/ibss_algorithm.R#L129

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant