Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd vs variances #18

Open
stephens999 opened this issue Oct 27, 2023 · 3 comments
Open

sd vs variances #18

stephens999 opened this issue Oct 27, 2023 · 3 comments

Comments

@stephens999
Copy link
Contributor

The output resid.sd appears to be the variance, not the sd.
The docs say it is the variance, so appear to be correct, but the name of the variable is very confusing.

@stephens999
Copy link
Contributor Author

the initialization of resid.sd in init_mr_ash uses the sd though
resid.sd <- sqrt((n-1)/n) * sd(y - X %*% b)

@stephens999 stephens999 changed the title resid.sd should be resid.var sd vs variances Oct 27, 2023
@stephens999
Copy link
Contributor Author

actually the prior sd may also be the prior variances!

Generally, mr.ash.alpha used variances (eg sigma2, sa2) so since we are interfacing
with that code we should probably stick with variances throughout to avoid errors.

@pcarbo
Copy link
Member

pcarbo commented Oct 27, 2023

Actually I think we were trying to make the interface more consistent with ashr; ash() has input argument mixsd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants