Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monochrome theme #77

Open
stephenmk opened this issue Feb 13, 2024 · 2 comments
Open

Monochrome theme #77

stephenmk opened this issue Feb 13, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@stephenmk
Copy link
Owner

stephenmk commented Feb 13, 2024

Feedback received from a user:

the crazy clashing tag colors and distracting elements in jitendex were driving me mad
hate the ugly tags and miscellaneous crap everywhere

I do think it might be good to put together a more monochromatic theme that tones down some of the brightness of the tags. It could be added to the "guides" section of my website along with the other style customizations.

@stephenmk stephenmk self-assigned this Feb 13, 2024
@stephenmk stephenmk added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 13, 2024
@watatomo
Copy link

watatomo commented Mar 8, 2024

I'll mention that the inline styles make it harder to style the theme, especially since I use a custom color scheme (Catppuccin, lol). Also, it's probably just me, but I prefer it when all the tags are on the same line rather than separating the dictionary source and the others.

@stephenmk
Copy link
Owner Author

the inline styles make it harder to style the theme

Yomitan doesn't have style classes. Inline styles are the only way to embed styles into the dictionary file. I have added various data attributes to the markup that users can target with their custom CSS selectors. See the example custom styles in the wiki.

I prefer it when all the tags are on the same line rather than separating the dictionary source and the others

The "dictionary source" tags are part of the Yomitan user interface, and the other tags are from the dictionary markup. They cannot be displayed together. There can also be multiple rows of "other tags" within a single entry. It wouldn't look good if I moved only the first "noun" tag in the entry for 壁 to the same line as the dictionary source tags.

noun

Repository owner locked and limited conversation to collaborators Mar 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants