Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Yomitan inline styles with CSS file #104

Open
stephenmk opened this issue Sep 16, 2024 · 3 comments
Open

Replace Yomitan inline styles with CSS file #104

stephenmk opened this issue Sep 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@stephenmk
Copy link
Owner

Yomitan recently added support for external CSS files, so inline styles are no longer necessary. This might greatly reduce the storage space consumed by Jitendex.

See: yomidevs/yomitan#1080

@stephenmk stephenmk self-assigned this Sep 16, 2024
@stephenmk stephenmk added the enhancement New feature or request label Sep 16, 2024
@stephenmk
Copy link
Owner Author

At least one roadblock: yomidevs/yomitan#1500

@Lanwara
Copy link

Lanwara commented Nov 17, 2024

Hey just wondering, if the inline styles disappear will Anki exports still have the required styles? Because I think it's great that this just works out of the box.

anki_zubS55ZobX

@stephenmk
Copy link
Owner Author

if the inline styles disappear will Anki exports still have the required styles?

Correct, Anki exports will continue to work correctly by default. If a Yomitan dictionary stores CSS styles in a separate file rather than writing them inline, then Yomitan will embed the entire contents of the CSS file in each Anki flashcard it creates. (These CSS files usually aren't larger than 10KB in size, so the extra storage space required probably isn't a concern).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants