Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested lists render inconsistently #13

Open
GuySartorelli opened this issue Nov 17, 2023 · 1 comment
Open

Nested lists render inconsistently #13

GuySartorelli opened this issue Nov 17, 2023 · 1 comment

Comments

@GuySartorelli
Copy link
Contributor

GuySartorelli commented Nov 17, 2023

Add the following to the kitchen link.

- This is a list with a nested list with a nested list
    1. This is the nested list. It's ordered.
        1) This is the nested-nested list. Wild.
    1. Back to the first list.
        * We can nest them like this too.
- cool, huh?

Even when you adjust the kitchen-sink-expected to just be whatever the output from the renderer is, it'll fail the test_it_parses_kitchen_sink_and_parsing_the_result_again_returns_the_same_result test.

The rendered result has additional line breaks that aren't in the original, and less padding than exists in the original.

@GuySartorelli GuySartorelli changed the title Nested lists fail kitchen sink tests Nested lists render inconsistently Nov 17, 2023
@GuySartorelli
Copy link
Contributor Author

I'm not sure what's adding the extra line breaks, but I suspect the incorrect padding (it's always less padding in the rendered result than the original) is a result of ignoring markerOffset (we can see in ListItemParser and in ListBlockStartParser that markerOffset should be added to the padding).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant