Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building.md build instructions are out of date #3451

Open
iamsmooth opened this issue Aug 5, 2019 · 3 comments · May be fixed by #3469
Open

building.md build instructions are out of date #3451

iamsmooth opened this issue Aug 5, 2019 · 3 comments · May be fixed by #3469

Comments

@iamsmooth
Copy link

Ubuntu 18.04 is apparently a supported or even recommended platform now and should be addressed in the build instructions.

I was looking at 0.21.0 and did not check any of the other releases but I would guess they are the same.

@iamsmooth
Copy link
Author

To follow up, as far as I can tell the existing 16.04 instructions work fine on 18.04 as well, so this may be as simple as changing the header to include both.

@iamsmooth iamsmooth changed the title building.md is missing build instructions for Ubuntu 18.04 building.md build instructions are out of date Aug 15, 2019
@iamsmooth
Copy link
Author

Also, CONFIG_MIRA is missing

@iamsmooth
Copy link
Author

iamsmooth commented Aug 15, 2019

Also @Gandalf-the-Grey notes:

also no info about nofiles limits, libboost-signals-dev might not be needed, submodules are no longer used, and I'm not sure about cmake options (I was providing them explicitly just in case) at least some of them are matching defaults

Ubuntu 14 LTS reached EOL (there's still extended support but that's irrelevant IMHO)

@Gandalf-the-Grey Gandalf-the-Grey linked a pull request Aug 19, 2019 that will close this issue
mvandeberg added a commit that referenced this issue Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant