Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve organization of code to format warnings differently for redaction / error objects / etc #106

Open
nbrooke opened this issue Jun 17, 2022 · 0 comments

Comments

@nbrooke
Copy link
Member

nbrooke commented Jun 17, 2022

Right now there are a couple problems with the way that the code is structured to pick how to format the output with required redaction / related objects / error objects / etc. There's a bunch of things that are early outs but that are if's rather than guards (which might be a little better), a bunch of very similar code between multiple forms of the logging functions (warn vs error).

It would be nice to clean that up, factor out some of the common code for generating the additional info strings into a helper function, make the picking of what to do either more consistently an if else tree OR more consistently guards rather than the current mix, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant