Skip to content

[RFC]: Add C implementations to base special math functions (tracking issue) #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
kgryte opened this issue Dec 2, 2022 · 29 comments · Fixed by #3058, #3061, #3072 or #3076 · May be fixed by #3377
Open

[RFC]: Add C implementations to base special math functions (tracking issue) #649

kgryte opened this issue Dec 2, 2022 · 29 comments · Fixed by #3058, #3061, #3072 or #3076 · May be fixed by #3377
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.

Comments

@kgryte
Copy link
Member

kgryte commented Dec 2, 2022 •
edited by anandkaranubc
Loading

Description

This RFC proposes adding C implementations to all base special math functions. The purpose of this issue is to serve as a tracking issue for adding C implementations.

Packages

  • abs
  • abs2
  • abs2f
  • absf
  • acos
  • acosf
  • acosd
  • acosdf
  • acosh
  • acoshf
  • acot
  • acotf
  • acotd
  • acotdf
  • acoth
  • acothf
  • acovercos
  • acovercosf
  • acoversin
  • acoversinf
  • acsc
  • acscf
  • acscd
  • acscdf
  • acsch
  • acschf
  • ahavercos
  • ahavercosf
  • ahaversin
  • ahaversinf
  • asec
  • asecf
  • asecd
  • asecdf
  • asech
  • asechf
  • asin
  • asinf
  • asind
  • asindf
  • asinf
  • asinh
  • asinhf
  • atan
  • atanf
  • atan2
  • atan2f
  • atand
  • atandf
  • atanh
  • atanhf
  • avercos
  • avercosf
  • aversin
  • aversinf
  • bernoulli
  • bernoullif
  • besselj0
  • besselj0f
  • besselj1
  • besselj1f
  • bessely0
  • bessely0f
  • bessely1
  • bessely1f
  • beta
  • betaf
  • betainc
  • betaincf
  • betaincinv
  • betaincinvf
  • betaln
  • betalnf
  • binet
  • binetf
  • binomcoef
  • binomcoeff
  • binomcoefln
  • binomcoeflnf
  • boxcox
  • boxcoxf
  • boxcox1p
  • boxcox1pf
  • boxcox1pinv
  • boxcox1pinvf
  • boxcoxinv
  • boxcoxinvf
  • cabs
  • cabs2
  • cabs2f
  • cabsf
  • cbrt
  • cbrtf
  • cceil
  • cceilf
  • cceiln
  • cceilnf
  • ccis
  • ccisf
  • ceil
  • ceil10
  • ceil10f
  • ceil2
  • ceil2f
  • ceilb
  • ceilbf
  • ceilf
  • ceiln
  • ceilnf
  • ceilsd
  • ceilsdf
  • cexp
  • cexpf
  • cflipsign
  • cflipsignf
  • cfloor
  • cfloorf
  • cfloorn
  • cfloornf
  • cidentity
  • cidentityf
  • cinv
  • cinvf
  • clamp
  • clampf
  • copysign
  • copysignf
  • cos
  • cosf
  • cosd
  • cosdf
  • cosh
  • coshf
  • cosm1
  • cosm1f
  • cospi
  • cospif
  • cot
  • cotf
  • cotd
  • cotdf
  • coth
  • cothf
  • covercos
  • covercosf
  • coversin
  • coversinf
  • cphase
  • cphasef
  • cpolar
  • cpolarf
  • cround
  • croundf
  • croundn
  • croundnf
  • csc
  • cscf
  • cscd
  • cscdf
  • csch
  • cschf
  • csignum
  • csignumf
  • deg2rad
  • deg2radf
  • digamma
  • digammaf
  • dirac-delta
  • dirac-deltaf
  • dirichlet-eta
  • dirichlet-etaf
  • ellipe
  • ellipef
  • ellipj
  • ellipjf
  • ellipk
  • ellipkf
  • erf
  • erff
  • erfc
  • erfcf
  • erfcinv
  • erfcinvf
  • erfcx
  • erfcxf
  • erfinv
  • erfinvf
  • exp
  • expf
  • exp10
  • exp10f
  • exp2
  • exp2f
  • expit
  • expitf
  • expm1
  • expm1f
  • expm1rel
  • expm1relf
  • factorial
  • factorialf
  • factorial2
  • factorial2f
  • factorialln
  • factoriallnf
  • falling-factorial
  • falling-factorialf
  • fast/*
  • fibonacci
  • fibonaccif
  • fibonacci-index
  • fibonacci-indexf
  • flipsign
  • flipsignf
  • floor
  • floor10
  • floor10f
  • floor2
  • floor2f
  • floorb
  • floorbf
  • floorf
  • floorn
  • floornf
  • floorsd
  • floorsdf
  • fmod
  • fmodf
  • fresnel
  • fresnelf
  • fresnelc
  • fresnelcf
  • fresnels
  • fresnelsf
  • frexp
  • frexpf
  • gamma
  • gammaf
  • gamma-delta-ratio
  • gamma-delta-ratiof
  • gamma-lanczos-sum
  • gamma-lanczos-sumf
  • gamma-lanczos-sum-expg-scaled
  • gamma-lanczos-sum-expg-scaledf
  • gamma1pm1
  • gamma1pm1f
  • gammainc
  • gammaincf
  • gammaincinv
  • gammaincinvf
  • gammaln
  • gammalnf
  • gammasgn
  • gammasgnf
  • gcd
  • gcdf
  • hacovercos
  • hacovercosf
  • hacoversin
  • hacoversinf
  • havercos
  • havercosf
  • haversin
  • haversinf
  • heaviside
  • heavisidef
  • hypot
  • hypotf
  • identity
  • identityf
  • inv
  • invf
  • kernel-betainc
  • kernel-betaincf
  • kernel-betaincinv
  • kernel-betaincinvf
  • kernel-cos
  • kernel-cosf
  • kernel-sin
  • kernel-sinf
  • kernel-tan
  • kernel-tanf
  • kronecker-delta
  • kronecker-deltaf
  • labs
  • lcm
  • lcmf
  • ldexp
  • ldexpf
  • ln
  • lnf
  • log
  • logf
  • log10
  • log10f
  • log1mexp
  • log1mexpf
  • log1p
  • log1pf
  • log1pexp
  • log1pexpf
  • log1pmx
  • log1pmxf
  • log2
  • log2f
  • logaddexp
  • logaddexpf
  • logit
  • logitf
  • lucas
  • lucasf
  • max
  • maxf
  • maxabs
  • maxabsf
  • maxabsn
  • maxn
  • min
  • minf
  • minabs
  • minabsf
  • minabsn
  • minmax
  • minmaxf
  • minmaxabs
  • minmaxabsf
  • minmaxabsn
  • minmaxn
  • minn
  • modf
  • modff
  • nanmax
  • nanmaxf
  • nanmin
  • nanminf
  • negafibonacci
  • negafibonaccif
  • negalucas
  • negalucasf
  • nonfibonacci
  • nonfibonaccif
  • pdiff
  • pdifff
  • polygamma
  • polygammaf
  • pow
  • powf
  • powm1
  • powm1f
  • rad2deg
  • rad2degf
  • ramp
  • rampf
  • rcbrt
  • rcbrtf
  • rempio2
  • rempio2f
  • riemann-zeta
  • riemann-zetaf
  • rising-factorial
  • rising-factorialf
  • round
  • roundf
  • round10
  • round10f
  • round2
  • round2f
  • roundb
  • roundbf
  • roundn
  • roundnf
  • roundsd
  • roundsdf
  • rsqrt
  • rsqrtf
  • sec
  • secd
  • secdf
  • secf
  • sici
  • sicif
  • signum
  • signumf
  • sin
  • sinf
  • sinc
  • sincf
  • sincos
  • sincosd
  • sincosdf
  • sincosf
  • sincospi
  • sincospif
  • sinh
  • sinhf
  • sinpi
  • sinpif
  • spence
  • spencef
  • sqrt
  • sqrt1pm1
  • sqrt1pm1f
  • sqrtf
  • sqrtpi
  • sqrtpif
  • tan
  • tanf
  • tand
  • tandf
  • tanh
  • tanhf
  • tribonacci
  • tribonaccif
  • trigamma
  • trigammaf
  • trunc
  • trunc10
  • trunc10f
  • trunc2
  • trunc2f
  • truncb
  • truncbf
  • truncf
  • truncn
  • truncnf
  • truncsd
  • truncsdf
  • vercos
  • vercosf
  • versin
  • versinf
  • wrap
  • wrapf
  • xlog1py
  • xlog1pyf
  • xlogy
  • xlogyf

Related Issues

None.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Enhancement Issue or pull request for enhancing existing functionality. and removed Feature Issue or pull request for adding a new feature. labels Dec 2, 2022
This was referenced Jan 30, 2024
Open
Open
@kgryte kgryte added difficulty: 3 Likely to be challenging but manageable. Accepted RFC feature request which has been accepted. priority: High High priority concern or feature request. labels Feb 25, 2024
This was referenced Mar 3, 2024
Closed
Closed
Closed
Closed
@Pratik772846
Copy link
Contributor

@kgryte I would like to work on this.

@Snehil-Shah Snehil-Shah mentioned this issue Mar 5, 2024
Closed
3 tasks
@Pratik772846 Pratik772846 mentioned this issue Mar 5, 2024
Closed
3 tasks
This was referenced Mar 5, 2024
Merged
Closed
Merged
@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pratik772846 I suggest picking one of the associated RFCs for updating a single package. This is a tracking issue.

@kgryte
Copy link
Member Author

kgryte commented Mar 6, 2024

@Pranavchiku As you've been managing a number of the RFCs and PRs, would you mind updating the OP to match the current state of implementations?

@kgryte kgryte added the Tracking Issue Tracking issue. label Mar 6, 2024
This was referenced Mar 7, 2024
Closed
Closed
Merged
@tudor-pagu tudor-pagu mentioned this issue Mar 7, 2024
Closed
3 tasks
@gunjjoshi gunjjoshi mentioned this issue Mar 7, 2024
Closed
3 tasks
@kawaho2 kawaho2 mentioned this issue Mar 7, 2024
Closed
3 tasks
@anandkaranubc anandkaranubc mentioned this issue May 15, 2025
Merged
1 task
kgryte added a commit that referenced this issue May 16, 2025
@vivekmaurya001 @kgryte
@stdlib-bot @gunjjoshi @anandkaranubc
feat: add math/base/special/gammasgnf

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
70d6643 
PR-URL: #3365
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Gunj Joshi <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
@anandkaranubc anandkaranubc mentioned this issue May 17, 2025
Merged
1 task
Planeshifter pushed a commit that referenced this issue May 18, 2025
@anandkaranubc @stdlib-bot
feat: add math/base/special/binomcoeff

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
35f5f7a 
PR-URL: #7000
Ref: #649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter pushed a commit that referenced this issue May 18, 2025
@anandkaranubc @stdlib-bot
feat: add C implementation for math/base/special/heavisidef

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9b48575 
PR-URL: #7022
Ref: #649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter pushed a commit that referenced this issue May 18, 2025
@gururaj1512 @stdlib-bot @anandkaranubc
feat: add math/base/special/negafibonaccif

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c888997 
PR-URL: #4939
Ref: #649

Signed-off-by: Gururaj Gurram <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Shabareesh Shetty <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
@anandkaranubc anandkaranubc mentioned this issue May 19, 2025
Open
1 task
Planeshifter pushed a commit that referenced this issue May 19, 2025
@Neerajpathak07 @anandkaranubc
feat: add C implementation for math/base/special/minmax

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
57b0e74 
PR-URL: #6296
Closes: #2106
Ref: #649

Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
This was referenced May 20, 2025
Open
Open
Merged
Open
Open
Open
kgryte pushed a commit that referenced this issue Jun 1, 2025
@ShabiShett07 @stdlib-bot
@gunjjoshi @anandkaranubc
feat: add C implementation for math/base/special/bessely1

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
d609d1f 
PR-URL: #4396
Ref: #649
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Gunj Joshi <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
kgryte added a commit that referenced this issue Jun 1, 2025
@anandkaranubc @kgryte
feat: add math/base/special/factorial2f

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
4eaa59f 
PR-URL: #6736
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Planeshifter pushed a commit that referenced this issue Jun 1, 2025
@anandkaranubc @stdlib-bot
feat: add math/base/special/atan2f

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
3c5ee39 
PR-URL: #7081
Ref: #649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
@anandkaranubc anandkaranubc mentioned this issue Jun 1, 2025
Open
1 task
@gururaj1512 gururaj1512 mentioned this issue Jun 1, 2025
Open
1 task
@anandkaranubc anandkaranubc mentioned this issue Jun 2, 2025
Open
kgryte added a commit that referenced this issue Jun 2, 2025
@gururaj1512 @kgryte
@stdlib-bot @anandkaranubc
feat: add math/base/special/wrapf

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7e4dc08 
PR-URL: #3055
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
anandkaranubc added a commit to anandkaranubc/stdlib that referenced this issue Jun 3, 2025
@gururaj1512 @kgryte
@stdlib-bot @anandkaranubc
feat: add math/base/special/wrapf
7e6a88b 
PR-URL: stdlib-js#3055
Ref: stdlib-js#649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Reviewed-by: Karan Anand <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Planeshifter pushed a commit that referenced this issue Jun 3, 2025
@anandkaranubc @stdlib-bot
feat: add math/base/special/rempio2f

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
9eef97f 
PR-URL: #6142
Ref: #649

Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Reviewed-by: Athan Reines <[email protected]>
Reviewed-by: Dhruvil Mehta <[email protected]>
@anandkaranubc anandkaranubc mentioned this issue Jun 4, 2025
Merged
1 task
Planeshifter pushed a commit that referenced this issue Jun 4, 2025
@Girish-Garg @anandkaranubc @stdlib-bot
feat: add math/base/special/kernel-sinf

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
c037257 
PR-URL: #6191
Ref: #649

Co-authored-by: Karan Anand <[email protected]>
Co-authored-by: stdlib-bot <[email protected]>
Reviewed-by:  Karan Anand <[email protected]>
Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
Planeshifter pushed a commit that referenced this issue Jun 4, 2025
@anandkaranubc
feat: add math/base/special/kernel-cosf

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
f873e1f 
PR-URL: #7201
Ref: #649

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Karan Anand <[email protected]>
kgryte added a commit that referenced this issue Jun 5, 2025
@Neerajpathak07 @kgryte
@stdlib-bot @anandkaranubc
feat: add math/base/special/tribonaccif

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
6724610 
PR-URL: #6066
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
Co-authored-by: Karan Anand <[email protected]>
Reviewed-by: Gunj Joshi <[email protected]>
Reviewed-by: Karan Anand <[email protected]>
kgryte added a commit that referenced this issue Jun 6, 2025
@anandkaranubc @kgryte @stdlib-bot
feat: add math/base/special/cinvf

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
e99f5d4 
PR-URL: #7007
Ref: #649
Co-authored-by: Athan Reines <[email protected]>
Reviewed-by: Athan Reines <[email protected]> 
Co-authored-by: stdlib-bot <[email protected]>
This was referenced Jun 6, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. difficulty: 3 Likely to be challenging but manageable. Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Tracking Issue Tracking issue.
Projects
None yet
Milestone
No milestone
9 participants
@Planeshifter @kgryte @gunjjoshi @Pranavchiku @sahil20021008 @Pratik772846 @Harsh-Mathur-1503 @anandkaranubc @Girish-Garg