[RFC]: Refactor random number generation in JS benchmarks for stats/base/dists (tracking issue) #4993
Open
[RFC]: Refactor random number generation in JS benchmarks for
stats/base/dists (tracking issue)#499312 of 18 issues completed
Description
This RFC proposes improving random number generation in JS benchmarks for remaining packages in stats/base/dists.
Sub-issues
Sub-issues
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
- Manage this item control shift u
Metadata
Metadata
Assignees
Labels
Pull requests adding or improving benchmarks for measuring performance.A good first issue for new contributors!Issue involves or relates to JavaScript.Request for comments. Feature requests and proposed changes.Tracking issue.Low degree of difficulty. Should be straightforward to implement and/or resolve.
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
stats/base/dists/weibull#4992stats/base/dists/weibull#4992stats/base/dists/triangular#4989stats/base/dists/weibull#4992stats/base/dists/uniform#4991stats/base/dists/signrank#4986stats/base/dists/t#4988stats/base/dists/rayleigh#4985stats/base/dists/poisson#4984stats/base/dists/planck#4983stats/base/dists/normal#4981stats/base/dists/lognormal#49799 remaining items
stats/base/dists/pareto-type1#4982stats/base/dists/studentized-range#4987ahmad-kashkoush commentedon Jan 31, 2025
Hi @anandkaranubc , I'm interested in closing some of these issues, are these issues aligned with project direction?
I want to assure that they will get merged right away
anandkaranubc commentedon Jan 31, 2025
Hii @ahmad-kashkoush, feel free to go ahead with creating PRs targeting these issues. Probably start with one, get it reviewed, and then proceed with creating more.
stats/base/dists/weibull#5011stats/base/dists/triangular#5015stats/base/dists/uniform#5027saurabhraghuvanshii commentedon Feb 5, 2025
if any one working on any issue please comment in that issue , it will be help full and there will be no 2 Pr for same issue .
stats/base/dists/weibull#4992anandkaranubc commentedon Feb 21, 2025
For everyone working on the refactoring issues above, can you all please update your PRs to also include the same changes that were made in #5296?
Specifically, the
set::*benchmarks inctorneed theirisnanchecks updated.Thanks @G4URAV001 for pointing out this bug.
stats/base/dists/laplace#5270saurabhraghuvanshii commentedon Feb 22, 2025
I didn't understand what was the and bug how this solve .
anandkaranubc commentedon Feb 22, 2025
Because in cases like these (where the random number generation occurs outside the benchmarking loops), specifically in the
ctor set::*benchmarks,yis being initialized as an array instead of a value. That is why theisnan(y)check appears to be a bug here.saurabhraghuvanshii commentedon Feb 22, 2025
that is , thanks @anandkaranubc
stats/base/dists/levy#5883