Skip to content

Commit 7a03310

Browse files
committed
Auto-generated commit
1 parent 9c4407c commit 7a03310

File tree

4 files changed

+16
-4
lines changed

4 files changed

+16
-4
lines changed

CHANGELOG.md

+12
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,24 @@
1616

1717
<!-- /.features -->
1818

19+
<section class="bug-fixes">
20+
21+
### Bug Fixes
22+
23+
- [`1aca9d3`](https://github.com/stdlib-js/stdlib/commit/1aca9d37e47e33c03b94bb5b128647c7387172e2) - update type defn
24+
25+
</section>
26+
27+
<!-- /.bug-fixes -->
28+
1929
<section class="commits">
2030

2131
### Commits
2232

2333
<details>
2434

35+
- [`40fc3a2`](https://github.com/stdlib-js/stdlib/commit/40fc3a218445c34a667237cadb74ae9417cc0392) - **chore:** add TODO _(by Athan Reines)_
36+
- [`1aca9d3`](https://github.com/stdlib-js/stdlib/commit/1aca9d37e47e33c03b94bb5b128647c7387172e2) - **fix:** update type defn _(by Athan Reines)_
2537
- [`266a064`](https://github.com/stdlib-js/stdlib/commit/266a064a8cc55b100a00d2ad98c84820d8f17653) - **style:** fix spacing _(by Athan Reines)_
2638
- [`6c020d3`](https://github.com/stdlib-js/stdlib/commit/6c020d33665c4aec232196fd86214b296ddc7d36) - **chore:** use relative paths to load package.json file _(by Philipp Burckhardt)_
2739
- [`6a6bc1d`](https://github.com/stdlib-js/stdlib/commit/6a6bc1da925c3c3f24463cf0d381d0d38e84868b) - **feat:** add `ndarray/base/fill` [(#2817)](https://github.com/stdlib-js/stdlib/pull/2817) _(by Muhammad Haris, Athan Reines)_

dist/index.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/types/index.d.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
/// <reference types="@stdlib/types"/>
2222

23-
import { typedndarray, complexndarray } from '@stdlib/types/ndarray';
23+
import { typedndarray, complexndarray, genericndarray } from '@stdlib/types/ndarray';
2424
import { ComplexLike } from '@stdlib/types/complex';
2525

2626
/**
@@ -101,7 +101,7 @@ declare function fill( x: complexndarray, value: number | ComplexLike ): void;
101101
* console.log( x.data );
102102
* // => <Float64Array>[ 10.0, 10.0, 10.0, 10.0, 10.0, 10.0 ]
103103
*/
104-
declare function fill<T = unknown>( x: typedndarray<T>, value: T ): void;
104+
declare function fill<T = unknown>( x: typedndarray<T> | genericndarray<T>, value: T ): void;
105105

106106

107107
// EXPORTS //

lib/main.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ function fill( x, value ) {
7979
v = broadcastScalar( value, getDtype( x ), getShape( x ), getOrder( x ) );
8080

8181
// Assign the fill value to each element of the input ndarray:
82-
assign( [ v, x ] );
82+
assign( [ v, x ] ); // TODO: consider replacing with ndarray/base/assign-scalar in order to avoid zero-dimensional ndarray creation and subsequent broadcasting
8383
}
8484

8585

0 commit comments

Comments
 (0)