-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing std::_Fake_copy_init
in MSVC build
#89
Comments
Thanks for your comment. I'll consider your recommendation. I'm not sure why you're running into a problem because I've been using the latest MSVC all along. |
I confirm that the bug still persists in branch I am using the same version of MSVC as in the initial report. The error message is for this like: https://github.com/stdgraph/graph-v2/blob/master/include/graph/detail/graph_cpo.hpp#L13 My single-file test project includes two graph headers in this order: #include <iostream>
#include <string>
#include <vector>
#include <graph/views/breadth_first_search.hpp>
#include <graph/graph.hpp> |
I'll work on getting a fix in, hopefully before I go on break next week.
Sent from Outlook<http://aka.ms/weboutlook>
From: Andrzej Krzemieński ***@***.***>
Sent: Friday, September 13, 2024 1:31 AM
To: stdgraph/graph-v2 ***@***.***>
Cc: Phil Ratzloff ***@***.***>; Comment ***@***.***>
Subject: Re: [stdgraph/graph-v2] Missing `std::_Fake_copy_init` in MSVC build (Issue #89)
I confirm that the bug still persists in branch master as of today: 3d572ef<3d572ef>
I am using the same version of MSVC as in the initial report.
The error message is for this like: https://github.com/stdgraph/graph-v2/blob/master/include/graph/detail/graph_cpo.hpp#L13
My single-file test project includes two graph headers in this order:
#include <iostream>
#include <string>
#include <vector>
#include <graph/views/breadth_first_search.hpp>
#include <graph/graph.hpp>
-
Reply to this email directly, view it on GitHub<#89 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AB7NKERVG7OZV7R6SXTY6PLZWJ2ADAVCNFSM6AAAAABOEMQJU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBYGA3DGOJWGA>.
You are receiving this because you commented.Message ID: ***@***.******@***.***>>
|
I'll create an independent set of definitions outside of MSVC & gcc, as you suggest. I'll try to get it in later this week. |
I've pushed a fix. I'd appreciate it if you could let me know whether it works for you or not. |
I am using Microsoft Visual C++ 2022, version 17.3.4, both std C++20, and the experimental newest C++.
The compilation of
std::graph::views::edges_breadth_first_search
fails with an error thatstd::_Fake_copy_init
is not defined. Removing this#ifndef
guard fixes the problem. I can see that other STL implementations (like this one) do have it defined.Maybe to enable thecompilation on any MSVC build this library should define its own type
std::graph::fake_copy_init
independent of the compiler used.The text was updated successfully, but these errors were encountered: