Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove magic from parse function #87

Open
stchris opened this issue Jul 1, 2022 · 0 comments
Open

Remove magic from parse function #87

stchris opened this issue Jul 1, 2022 · 0 comments

Comments

@stchris
Copy link
Owner

stchris commented Jul 1, 2022

Right now the parse function "magically" detects if the passed input is a string containing XML, an URL or a filename. While this seemed convenient at the time it might cause some issues.

Proposal:

  • add parse_file which takes a path
  • add parse_xml_string which takes an XML string
  • add parse_url which takes an URL

The parse function could be marked as deprecated and removed in version 2.0 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant