feat: elevate and highlight wallet CTAs on wallet home screen #21985
+162
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
briansztamfater
added
request-manual-qa
wallet-core
Jenkins BuildsClick to see older builds (18)
|
briansztamfater
force-pushed
the
feat/elevate-wallet-ctas
branch
6 times, most recently
from
ca748e5 to
b479ecf
Compare
briansztamfater
changed the title
Signed-off-by: Brian Sztamfater <[email protected]>
briansztamfater
force-pushed
the
feat/elevate-wallet-ctas
branch
from
b479ecf to
8818311
Compare
briansztamfater
requested review from
alwx,
shivekkhurana,
vkjr,
smohamedjavid,
clauxx and
mohsen-ghafouri
alwx
approved these changes
Jan 27, 2025
clauxx
reviewed
Jan 27, 2025
| cards (conj account-cards-data (new-account-card-data)) | ||
| [init-loaded? set-init-loaded] (rn/use-state false) | ||
| {:keys [formatted-balance]} (rf/sub [:wallet/aggregated-token-values-and-balance]) | ||
| multiple-accounts? (> (count account-cards-data) 1) |
There was a problem hiding this comment.
could we isolate these changes into a separate component (quo/wallet-ctas with all the props it needs) to avoid this one getting too big?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21976
Summary
This PR adds wallet CTAs to our wallet home screen, and handle the case for each flow when they are initiated from the wallet home without any preselected token.
Platforms
Areas that may be impacted
Steps to test
We should also verify the current Send / Bridge / Swap / Buy / Receive flows where not broken by initiating them from different screens and actions.
status: ready