-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dapps transactions instantly rejected #21973
Conversation
Jenkins BuildsClick to see older builds (14)
|
100% of end-end tests have passed
Passed tests (8)Click to expandClass TestWalletOneDevice:
Class TestWalletMultipleDevice:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
Class TestCommunityMultipleDeviceMerged:
|
89% of end-end tests have passed
Failed tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestFallbackMultipleDevice:
Expected to fail tests (3)Click to expandClass TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Passed tests (50)Click to expandClass TestActivityMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletMultipleDevice:
Class TestWalletOneDevice:
Class TestCommunityOneDeviceMerged:
Class TestFallbackMultipleDevice:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestDeepLinksOneDevice:
|
@clauxx thank you for the quick fix! Tested signing available requests on https://se-sdk-dapp.vercel.app/ No issues from my side, failed e2e are not PR related. PR is ready for merge. |
@pavloburykh the status-go pr was merged, so i pushed a commit here to point to status-go's develop. Not sure if another check is needed for this. |
@clauxx Probably the best would be to create a new tag in status-go including the relevant commits and point this PR to the new tag, so we can properly merge this |
@clauxx can we do as was suggested by Brian? It would be great to get these changes into mobile develop ASAP, as we need it to unblock #21785. |
@pavloburykh done 👍 LMK if it can be merged when the CI is done. |
Already merged) thanks. |
fixes #21967
status-go #6274
Summary
Dapps transactions would be instantly rejected due to a recent regression in status-go.
status: ready
Risk
Tick one: