Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Go 1.22 or 1.23 #6254

Open
igor-sirotin opened this issue Jan 15, 2025 · 2 comments · May be fixed by #6258
Open

Upgrade to Go 1.22 or 1.23 #6254

igor-sirotin opened this issue Jan 15, 2025 · 2 comments · May be fixed by #6258
Assignees
@siddarthkay
Labels
go Pull requests that update Go code infra

Comments

@igor-sirotin
Copy link
Collaborator

Reasoning

  1. We currently use Go 1.21, which supported finished on 13.08.2024.cmd/link: issues with Xcode 16 beta [freeze exception] golang/go#68088

  2. Go 1.21 doesn't work with XCode 16: cmd/link: issues with Xcode 16 beta [freeze exception] golang/go#68088
    I faced this issue when trying to build status-desktop, because local mockgen was rebuilt with xcode 16.

    mockgen issue details 
     mockgen --version                                                      
 [1]    15208 killed     mockgen --version

    which is because of this

    codesign -v $(go env GOPATH)/bin/mockgen     
/Users/igorsirotin/go/bin/mockgen: invalid signature (code or signature have been modified)
In architecture: arm64

1.22 or 1.23?

Go 1.22 support will end with the release of Go 1.24, which is expected to happen in February 2025.

So I believe we must upgrade to 1.23 right away. And then perhaps also upgrade to 1.24 as soon as it's release, while the upgrade flow is fresh in mind.
@igor-sirotin igor-sirotin added go Pull requests that update Go code infra labels Jan 15, 2025
@siddarthkay siddarthkay self-assigned this Jan 15, 2025
@siddarthkay siddarthkay linked a pull request Jan 16, 2025 that will close this issue
Open
2 tasks
@siddarthkay
Copy link
Contributor

siddarthkay commented Jan 16, 2025 •
edited
Loading

This should be done in stages.

Each stage would be a PR and will have impact on both mobile, Desktop clients, so those changes would require QA.

@siddarthkay siddarthkay mentioned this issue Jan 16, 2025
Open
@arnetheduck
Copy link
Member

#6240 is relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siddarthkay siddarthkay

Labels
go Pull requests that update Go code infra
Projects
Status Desktop/Mobile Board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci_: upgrade go to 1.22 status-im/status-go
3 participants
@arnetheduck @igor-sirotin @siddarthkay