fix: proper env variable naming #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I welcome this addition, but can you please document this behavior in the README? You can also include a link the IEEE spec in the code. |
|
Will do! Actually found a bug in this PR, so will fix that and adjust the Readme 👍 |
|
@zah done ;-) I have also taken the liberty to adjust the README a bit to communicate the library's current capabilities better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the way how the env. variables names are defined from the parameter names. Especially it follows the convention of using solely
uppercase letters, digits, and the '_' (underscore)as specified in IEEE spec.While the env. variables are currently not wired to be used automatically if somebody used the
Envvarmanually, then for them merging this PR would be breaking change, yet IMHO, the current implementation is broken and not possible to use as, for example, my shell (fish) does not even allow me to define env. variable with names containing-.Btw. I am Nim novice so if you have some code improvement suggestions, please let me know ;-)
Closes #68
Closes #21