Fix statsig context race condition (#236)

kenny-statsig · web-flow · commit 14ddbeec19e0 · 2024-10-08T11:59:39.000-07:00
Lock on store when reading the spec source
diff --git a/client.go b/client.go
@@ -82,6 +82,8 @@ func newClientImpl(sdkKey string, options *Options) (*Client, *initContext) {
 
 func (c *Client) init(context *initContext) {
 	c.evaluator.initialize(context)
+	c.evaluator.store.mu.RLock()
+	defer c.evaluator.store.mu.RUnlock()
 	context.Success = c.evaluator.store.source != sourceUninitialized
 	context.Source = c.evaluator.store.source
 }

Original file line number	Diff line number	Diff line change
`@@ -82,6 +82,8 @@ func newClientImpl(sdkKey string, options Options) (Client, *initContext) {`
`82`	`82`
`83`	`83`	`func (c Client) init(context initContext) {`
`84`	`84`	`c.evaluator.initialize(context)`
	`85`	`+ c.evaluator.store.mu.RLock()`
	`86`	`+ defer c.evaluator.store.mu.RUnlock()`
`85`	`87`	`context.Success = c.evaluator.store.source != sourceUninitialized`
`86`	`88`	`context.Source = c.evaluator.store.source`
`87`	`89`	`}`