Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use int64 types? #4

Open
kevinburke1 opened this issue Mar 26, 2020 · 1 comment
Open

Use int64 types? #4

kevinburke1 opened this issue Mar 26, 2020 · 1 comment

Comments

@kevinburke1
Copy link

Per the specification available at https://github.com/b/statsd_spec, gauges can take any uint64 value and counters can take any int64 value. Using an int for gauge raises the possibility of measuring a negative number, or attempting to pass a value that's too large for the int type on a given machine.

Should we change the type definitions to better match the specification?

@kevinburke1
Copy link
Author

Possibly a dupe of statsd/client-interface#1, there has never been a better time to do the right thing, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant