Change count()>0 comparsions to !== []

Author: john-shaffer

src/DetectSitemapsURLs.php

@@ -102,7 +102,7 @@ public static function detect( string $wp_site_url ): \Iterator {
                 foreach ( $robotsmaps as $robotsmap ) {
                     $sitemaps[ $robotsmap ] = [];
                 }
-                if ( STATIC_DEPLOY_DEBUG && count( $sitemaps ) > 0 ) {
+                if ( STATIC_DEPLOY_DEBUG && $sitemaps !== [] ) {
                     WsLog::d( 'Found sitemaps: ' . implode( ', ', array_keys( $sitemaps ) ) );
                 }
             }

src/DetectedFiles.php

@@ -104,7 +104,7 @@ public static function addPathsIter(
             }
 
             // INSERT IGNORE new paths
-            if ( count( $insert_values ) > 0 ) {
+            if ( $insert_values !== [] ) {
                 $insert_rows = count( $insert_values ) / 2;
                 $placeholders = array_fill( 0, $insert_rows, '(%s,%s)' );
                 // phpcs:ignore WordPress.DB.DirectDatabaseQuery
@@ -121,7 +121,7 @@ public static function addPathsIter(
             }
 
             // UPDATE changed filenames
-            if ( count( $update_values ) > 0 ) {
+            if ( $update_values !== [] ) {
                 $update_rows = count( $update_values ) / 2;
                 for ( $i = 0; $i < $update_rows; $i++ ) {
                     $filename = $update_values[ $i * 2 ];

tests/unit/SitemapDownloadTest.php

@@ -17,7 +17,7 @@ public function testDownload( $url ) {
         $parser->parse( $url );
         $this->assertTrue( is_array( $parser->getSitemaps() ) );
         $this->assertTrue( is_array( $parser->getURLs() ) );
-        $this->assertTrue( count( $parser->getSitemaps() ) > 0 || count( $parser->getURLs() ) > 0 );
+        $this->assertTrue( $parser->getSitemaps() !== [] || $parser->getURLs() !== [] );
         foreach ( $parser->getSitemaps() as $url => $tags ) {
             $this->assertTrue( is_string( $url ) );
             $this->assertTrue( is_array( $tags ) );